drivers/amdgpu: Remove redundant NULL check before kfree()
authorEdward O'Callaghan <funfunctor@folklore1984.net>
Tue, 12 Jul 2016 00:17:54 +0000 (10:17 +1000)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 29 Jul 2016 18:36:49 +0000 (14:36 -0400)
Found-by: Coccinelle
Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Reviewed-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c

index ee95e950a19b054b3ffcb2038e705f118f32fc41..4cd857ff73ff426be6f18ef37636cb09cb0b67a4 100644 (file)
@@ -1065,8 +1065,7 @@ static int amdgpu_cgs_acpi_eval_object(struct cgs_device *cgs_device,
        }
 
 error:
-       if (obj != NULL)
-               kfree(obj);
+       kfree(obj);
        kfree((void *)input.pointer);
        return result;
 }
index 7a705cee0cc23624b7bc131601460cd317e817c6..bbdedec150f9a9a3cdddb70e7d7feced653f94ae 100644 (file)
@@ -77,8 +77,7 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
 
        result = phm_run_table(hwmgr, rt_table, input, output, temp_storage);
 
-       if (NULL != temp_storage)
-               kfree(temp_storage);
+       kfree(temp_storage);
 
        return result;
 }