drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 27 Jun 2015 20:05:31 +0000 (22:05 +0200)
committerRob Clark <robdclark@gmail.com>
Sat, 15 Aug 2015 22:27:17 +0000 (18:27 -0400)
The dsi_destroy() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/dsi/dsi.c

index 1f2561e2ff718f2f305b2a1891a26ab6cf1e3623..dc4f38f7028652ea466a5d780b7a6f5002e2d53d 100644 (file)
@@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev)
        return msm_dsi;
 
 fail:
-       if (msm_dsi)
-               dsi_destroy(msm_dsi);
-
+       dsi_destroy(msm_dsi);
        return ERR_PTR(ret);
 }