regulator: AXP20x: fix wrong call to of_find_node_by_name
authorBoris BREZILLON <boris.brezillon@free-electrons.com>
Mon, 19 May 2014 08:25:30 +0000 (10:25 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 19 May 2014 16:40:06 +0000 (17:40 +0100)
The of_find_node_by_name function will search for a DT node named
"regulators" after the provided np node, but will not ensure that this node
is a child of np.
This might result in retrieving a "regulators" node that is not related to
the axp20x PMIC.

Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
Acked-by: Carlo Caione <carlo@caione.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/axp20x-regulator.c

index 78a29e60f53a3156e53f1d73510d25cc0850ed0b..61ae4d4fbdd0c8ef63ef0c39310ae427ac87d156 100644 (file)
@@ -188,7 +188,7 @@ static int axp20x_regulator_parse_dt(struct platform_device *pdev)
        if (!np)
                return 0;
 
-       regulators = of_find_node_by_name(np, "regulators");
+       regulators = of_get_child_by_name(np, "regulators");
        if (!regulators) {
                dev_warn(&pdev->dev, "regulators node not found\n");
        } else {