ACPI / PNP: Replace faulty is_hex_digit() by isxdigit()

0 is ascii for NULL. Hex digit matching should be from '0'.
Faulty version returns true for #,$,%,& etc.

Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
index 4ddb0dca56f6c441ccb30029109d3671b45d456f..996fa1959eeacdc8335b0844eddbcf810bff9846 100644 (file)
--- a/drivers/acpi/acpi_pnp.c
+++ b/drivers/acpi/acpi_pnp.c
@@ -12,6 +12,7 @@
 
 #include <linux/acpi.h>
 #include <linux/module.h>
+#include <linux/ctype.h>
 
 static const struct acpi_device_id acpi_pnp_device_ids[] = {
        /* soc_button_array */
@@ -320,11 +321,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
        {""},
 };
 
-static bool is_hex_digit(char c)
-{
-       return (c >= 0 && c <= '9') || (c >= 'A' && c <= 'F');
-}
-
 static bool matching_id(char *idstr, char *list_id)
 {
        int i;
@@ -335,7 +331,7 @@ static bool matching_id(char *idstr, char *list_id)
        for (i = 3; i < 7; i++) {
                char c = toupper(idstr[i]);
 
-               if (!is_hex_digit(c)
+               if (!isxdigit(c)
                    || (list_id[i] != 'X' && c != toupper(list_id[i])))
                        return false;
        }