projects / GitHub / LineageOS / android_kernel_samsung_universal7580.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 2a38e6d)
sctp: integer overflow in sctp_auth_create_key()
authorXi Wang <xi.wang@gmail.com>
Tue, 22 Nov 2011 15:55:30 +0000 (15:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Nov 2011 05:31:45 +0000 (00:31 -0500)
The previous commit 30c2235c is incomplete and cannot prevent integer
overflows. For example, when key_len is 0x80000000 (INT_MAX + 1), the
left-hand side of the check, (INT_MAX - key_len), which is unsigned,
becomes 0xffffffff (UINT_MAX) and bypasses the check.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

No differences found