BUG_ON on kernel misbehavior on A100U2W driver
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 15 Jul 2008 21:18:38 +0000 (17:18 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 15 Jul 2008 21:30:56 +0000 (14:30 -0700)
With broken Sparc64 IOMMU accounting, the kernel submits larger requests
then allowed.  Better to crash on BUG than corrupt memory.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/a100u2w.c

index 1e8bdd45783462ecda77c3413bfaab8b4aafe813..f5051f4301d78515f9cec1cf29331ff10db9e1cb 100644 (file)
@@ -866,6 +866,7 @@ static void inia100_build_scb(struct orc_host * host, struct orc_scb * scb, stru
 
        count_sg = scsi_dma_map(cmd);
        BUG_ON(count_sg < 0);
+       BUG_ON(count_sg > TOTAL_SG_ENTRY);
 
        /* Build the scatter gather lists */
        if (count_sg) {