md/raid5: suspend shouldn't affect read requests.
authorNeilBrown <neilb@suse.de>
Wed, 1 Jul 2009 03:15:35 +0000 (13:15 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 1 Jul 2009 03:15:35 +0000 (13:15 +1000)
md allows write to regions on an array to be suspended temporarily.
This allows user-space to participate is aspects of reshape.
In particular, data can be copied with not risk of a race.
We should not be blocking read requests though, so don't.

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c

index 92ef9b6abfc7a7bb327d959d3e00964694c1d706..1f444ae07f89efb4e4aeaa81078ef96abde53eda 100644 (file)
@@ -3702,7 +3702,8 @@ static int make_request(struct request_queue *q, struct bio * bi)
                        /* FIXME what if we get a false positive because these
                         * are being updated.
                         */
-                       if (logical_sector >= mddev->suspend_lo &&
+                       if (bio_data_dir(bi) == WRITE &&
+                           logical_sector >= mddev->suspend_lo &&
                            logical_sector < mddev->suspend_hi) {
                                release_stripe(sh);
                                schedule();