net: stmmac: dwmac1000: provide multicast filter fallback
authorJonathan McDowell <noodles@earth.li>
Wed, 12 Aug 2020 19:37:01 +0000 (20:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 07:48:18 +0000 (09:48 +0200)
commit 592d751c1e174df5ff219946908b005eb48934b3 upstream.

If we don't have a hardware multicast filter available then instead of
silently failing to listen for the requested ethernet broadcast
addresses fall back to receiving all multicast packets, in a similar
fashion to other drivers with no multicast filter.

Cc: stable@vger.kernel.org
Signed-off-by: Jonathan McDowell <noodles@earth.li>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

index f76d4a7281af052d7dd140bb2aaf8d7df0e40f8b..f07d9d3456a4fb8f319da56b6f1f9e3dc0bbf9af 100644 (file)
@@ -176,6 +176,9 @@ static void dwmac1000_set_filter(struct mac_device_info *hw,
                value = GMAC_FRAME_FILTER_PR;
        } else if (dev->flags & IFF_ALLMULTI) {
                value = GMAC_FRAME_FILTER_PM;   /* pass all multi */
+       } else if (!netdev_mc_empty(dev) && (mcbitslog2 == 0)) {
+               /* Fall back to all multicast if we've no filter */
+               value = GMAC_FRAME_FILTER_PM;
        } else if (!netdev_mc_empty(dev)) {
                struct netdev_hw_addr *ha;