ALSA: hda: constify attribute_group structures.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 29 Jun 2017 10:37:01 +0000 (16:07 +0530)
committerTakashi Iwai <tiwai@suse.de>
Thu, 29 Jun 2017 16:20:21 +0000 (18:20 +0200)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/device.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
    995     608       0    1603     643 sound/pci/hda/hda_sysfs.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   1035     544       0    1579     62b sound/pci/hda/hda_sysfs.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_sysfs.c

index 9739fce9e032c3a2126a75b1148c21c5e3502bdd..9b7efece4484a65eda479511dd00d3a02abacf00 100644 (file)
@@ -761,7 +761,7 @@ static struct attribute *hda_dev_attrs[] = {
        NULL
 };
 
-static struct attribute_group hda_dev_attr_group = {
+static const struct attribute_group hda_dev_attr_group = {
        .attrs  = hda_dev_attrs,
 };