iommu/amd: Drop null test before destroy functions
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 13 Sep 2015 12:15:31 +0000 (14:15 +0200)
committerJoerg Roedel <jroedel@suse.de>
Tue, 29 Sep 2015 13:38:38 +0000 (15:38 +0200)
Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL) {
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
  x = NULL;
-}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd_iommu_init.c

index ea2afefe8e5731f56ec837899dbd4321729e122b..3ba1ee709824d1396bbc31bf7a731c1204cb1c2f 100644 (file)
@@ -1755,11 +1755,8 @@ static void __init free_on_init_error(void)
        free_pages((unsigned long)irq_lookup_table,
                   get_order(rlookup_table_size));
 
-       if (amd_iommu_irq_cache) {
-               kmem_cache_destroy(amd_iommu_irq_cache);
-               amd_iommu_irq_cache = NULL;
-
-       }
+       kmem_cache_destroy(amd_iommu_irq_cache);
+       amd_iommu_irq_cache = NULL;
 
        free_pages((unsigned long)amd_iommu_rlookup_table,
                   get_order(rlookup_table_size));