pkt_sched: sch_qfq: remove redundant -if- control statement
authorAndrea Parri <parri.andrea@gmail.com>
Tue, 16 Jun 2015 22:16:59 +0000 (00:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 Jun 2015 16:47:24 +0000 (09:47 -0700)
The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
because already performed in hlist_del_init(), so remove it.

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_qfq.c

index 3ec7e88a43cab2df5e012d3c5216bc31b75eafe3..b8d73bca683cc25d946163d9e856d8ed332ad4d7 100644 (file)
@@ -339,8 +339,7 @@ static struct qfq_aggregate *qfq_choose_next_agg(struct qfq_sched *);
 
 static void qfq_destroy_agg(struct qfq_sched *q, struct qfq_aggregate *agg)
 {
-       if (!hlist_unhashed(&agg->nonfull_next))
-               hlist_del_init(&agg->nonfull_next);
+       hlist_del_init(&agg->nonfull_next);
        q->wsum -= agg->class_weight;
        if (q->wsum != 0)
                q->iwsum = ONE_FP / q->wsum;