Revert "drm/i915/dp: Ratelimit DP aux timeout messages"
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 23 Feb 2017 11:51:02 +0000 (11:51 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 23 Feb 2017 13:14:06 +0000 (13:14 +0000)
This reverts commit 7ee686034b8b "drm/i915/dp: Ratelimit DP aux timeout
messages" as although it successfully squelches the debug messages, when
it does so it generates a warning instead. CI lights up orange with all
the warnings!

In its current incarnation DRM_DEBUG_RATELIMITED is not usable for us,
and we need to first teach lib/ratelimit.c not to warn when used for
debug messages.

Fixes: 7ee686034b8b ("drm/i915/dp: Ratelimit DP aux timeout messages")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lyude <lyude@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Link: http://patchwork.freedesktop.org/patch/msgid/20170223115102.7059-1-chris@chris-wilson.co.uk
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
drivers/gpu/drm/i915/intel_dp.c

index fca0fcade2d6946213f1fa0c6c4ec4064937d470..024798a9c01613120139f1e59f46470241b746fb 100644 (file)
@@ -1121,8 +1121,7 @@ done:
        /* Timeouts occur when the device isn't connected, so they're
         * "normal" -- don't fill the kernel log with these */
        if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
-               DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch timeout status 0x%08x\n",
-                                         status);
+               DRM_DEBUG_KMS("dp_aux_ch timeout status 0x%08x\n", status);
                ret = -ETIMEDOUT;
                goto out;
        }