[CPUFREQ] Fix another notifier leak in powernow-k8.
authorDave Jones <davej@redhat.com>
Wed, 24 Nov 2010 02:29:31 +0000 (21:29 -0500)
committerDave Jones <davej@redhat.com>
Tue, 1 Mar 2011 23:49:44 +0000 (18:49 -0500)
Do the notifier registration later, so we don't have to worry
about freeing it if we fail the msr allocation.

Signed-off-by: Dave Jones <davej@redhat.com>
arch/x86/kernel/cpu/cpufreq/powernow-k8.c

index 302963fb4dc3438d6a8f5f11d03852a239c4d2f2..c567dec854f69f865bc92105c55cc7066cc06c6e 100644 (file)
@@ -1556,14 +1556,14 @@ static int __cpuinit powernowk8_init(void)
 
                cpb_capable = true;
 
-               register_cpu_notifier(&cpb_nb);
-
                msrs = msrs_alloc();
                if (!msrs) {
                        printk(KERN_ERR "%s: Error allocating msrs!\n", __func__);
                        return -ENOMEM;
                }
 
+               register_cpu_notifier(&cpb_nb);
+
                rdmsr_on_cpus(cpu_online_mask, MSR_K7_HWCR, msrs);
 
                for_each_cpu(cpu, cpu_online_mask) {