GFS2: Fix panic in glock memory shrinker
authorBenjamin Marzinski <bmarzins@redhat.com>
Tue, 30 Jun 2009 18:51:11 +0000 (13:51 -0500)
committerSteven Whitehouse <swhiteho@redhat.com>
Thu, 30 Jul 2009 09:59:28 +0000 (10:59 +0100)
It is possible for gfs2_shrink_glock_memory() to check a glock for
demotion
that's in the process of being freed by gfs2_glock_put().  In this case,
gfs2_shrink_glock_memory() will acquire a new reference to this glock,
and
then try to free the glock itself when it drops the refernce.  To solve
this, gfs2_shrink_glock_memory() just needs to check if the glock is in
the process of being freed, and if so skip it without ever unlocking the
lru_lock.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Acked-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/glock.c

index fdb796c4f940915b289b044efab02afb3413a076..827136ee794cd485c48ebda26b122c0613de97d3 100644 (file)
@@ -1314,6 +1314,10 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask)
                list_del_init(&gl->gl_lru);
                atomic_dec(&lru_count);
 
+               /* Check if glock is about to be freed */
+               if (atomic_read(&gl->gl_ref) == 0)
+                       continue;
+
                /* Test for being demotable */
                if (!test_and_set_bit(GLF_LOCK, &gl->gl_flags)) {
                        gfs2_glock_hold(gl);