irqchip/bcm2836: Tolerate IRQs while no flag is set in ISR
authorAndrea Merello <andrea.merello@gmail.com>
Sat, 26 Dec 2015 21:47:23 +0000 (13:47 -0800)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 29 Dec 2015 10:40:45 +0000 (11:40 +0100)
On my RPi2 I got a lot of:
unexpected IRQ trap at vector 00

This happens because bcm2836_arm_irqchip_handle_irq() is sometimes
invoked even if the ISR is clear, and this case is not handled.

This patch explicitly handle this case, fixing the kernel complaints
about the bad IRQ lookup.

Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Eric Anholt <eric@anholt.net>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Lee Jones <lee@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-rpi-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1451166444-11044-4-git-send-email-eric@anholt.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-bcm2836.c

index 59ac40c3955159f57e266349842b9c20d034216f..bb8f234b6b73633c79697138ad339a4648fb00a2 100644 (file)
@@ -177,7 +177,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs)
                writel(1 << ipi, mailbox0);
                handle_IPI(ipi, regs);
 #endif
-       } else {
+       } else if (stat) {
                u32 hwirq = ffs(stat) - 1;
 
                handle_IRQ(irq_linear_revmap(intc.domain, hwirq), regs);