greybus: operation: clean up greybus_message_sent
authorJohan Hovold <johan@hovoldconsulting.com>
Wed, 22 Jul 2015 15:49:18 +0000 (17:49 +0200)
committerGreg Kroah-Hartman <gregkh@google.com>
Wed, 22 Jul 2015 18:10:33 +0000 (11:10 -0700)
Add connection variable to greybus_message_sent.

This will be put to more use by a follow-up up patch.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Tested-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/operation.c

index e98fc656c98b5a06c74362965f970e9471197e97..6b87bcd6361544e0584d9c6647cb7a0bcbca5b9b 100644 (file)
@@ -778,7 +778,8 @@ err_put:
 void greybus_message_sent(struct greybus_host_device *hd,
                                        struct gb_message *message, int status)
 {
-       struct gb_operation *operation;
+       struct gb_operation *operation = message->operation;
+       struct gb_connection *connection = operation->connection;
 
        /*
         * If the message was a response, we just need to drop our
@@ -790,10 +791,9 @@ void greybus_message_sent(struct greybus_host_device *hd,
         * attempting to send it, record that as the result of
         * the operation and schedule its completion.
         */
-       operation = message->operation;
        if (message == operation->response) {
                if (status) {
-                       dev_err(&operation->connection->dev,
+                       dev_err(&connection->dev,
                                "error sending response: %d\n", status);
                }
                gb_operation_put_active(operation);