be2net: define macro for_all_tx_queues_on_eq()

Replace the for() loop that traverses all the TX queues on an EQ
with the macro for_all_tx_queues_on_eq(). With this expalnatory
name, the one line comment is not required anymore.

Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index d952ca2c0678c30c5c972c390852298f423d715c..a9f239adc3e3a7db481026e31367281ce6d1e6f5 100644 (file)
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -621,6 +621,10 @@ extern const struct ethtool_ops be_ethtool_ops;
        for (i = eqo->idx, rxo = &adapter->rx_obj[i]; i < adapter->num_rx_qs;\
                 i += adapter->num_evt_qs, rxo += adapter->num_evt_qs)
 
+#define for_all_tx_queues_on_eq(adapter, eqo, txo, i)                  \
+       for (i = eqo->idx, txo = &adapter->tx_obj[i]; i < adapter->num_tx_qs;\
+               i += adapter->num_evt_qs, txo += adapter->num_evt_qs)
+
 #define is_mcc_eqo(eqo)                        (eqo->idx == 0)
 #define mcc_eqo(adapter)               (&adapter->eq_obj[0])
 

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index b31b0f0789dbb6389e545104c2a52b01ec0f2b6c..1b1fbbfcf3ad519fe52da343893d094cfcf2ea43 100644 (file)
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -2503,12 +2503,12 @@ int be_poll(struct napi_struct *napi, int budget)
        struct be_adapter *adapter = eqo->adapter;
        int max_work = 0, work, i, num_evts;
        struct be_rx_obj *rxo;
+       struct be_tx_obj *txo;
 
        num_evts = events_get(eqo);
 
-       /* Process all TXQs serviced by this EQ */
-       for (i = eqo->idx; i < adapter->num_tx_qs; i += adapter->num_evt_qs)
-               be_process_tx(adapter, &adapter->tx_obj[i], i);
+       for_all_tx_queues_on_eq(adapter, eqo, txo, i)
+               be_process_tx(adapter, txo, i);
 
        if (be_lock_napi(eqo)) {
                /* This loop will iterate twice for EQ0 in which