drm/i915: Fix test on inputs for vma_compare()
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 3 Nov 2016 20:08:52 +0000 (20:08 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 3 Nov 2016 21:00:43 +0000 (21:00 +0000)
When supplying a view to vma_compare() it is required that the supplied
i915_address_space is the global GTT. I tested the VMA instead (which is
the current position in the rbtree and maybe from any address space).

Reported-by: Matthew Auld <matthew.auld@intel.com>
Tested-by: Matthew Auld <matthew.auld@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98579
Fixes: db6c2b4151f2 ("drm/i915: Store the vma in an rbtree...")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161103200852.23431-1-chris@chris-wilson.co.uk
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
drivers/gpu/drm/i915/i915_gem_gtt.c

index 0c1f5b4750b6db52d82e5f491f179fe8b8e8bf45..cad6de65947d5cb1fa29633ebd0e9f91a910aa28 100644 (file)
@@ -3425,7 +3425,7 @@ static inline long vma_compare(struct i915_vma *vma,
                               struct i915_address_space *vm,
                               const struct i915_ggtt_view *view)
 {
-       GEM_BUG_ON(view && !i915_vma_is_ggtt(vma));
+       GEM_BUG_ON(view && !i915_is_ggtt(vm));
 
        if (vma->vm != vm)
                return vma->vm - vm;