net: dsa: move port state setters

Add a new port.c file to hold all DSA port-wide logic. This patch moves
in the code which sets a port state.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/dsa/Makefile b/net/dsa/Makefile
index f8c0251d1f4339ac61fffc6058e5ce0937560da7..90e5aa6f7d0f2e918810249cc13d8551de90d600 100644 (file)
--- a/net/dsa/Makefile
+++ b/net/dsa/Makefile
@@ -1,6 +1,6 @@
 # the core
 obj-$(CONFIG_NET_DSA) += dsa_core.o
-dsa_core-y += dsa.o slave.o dsa2.o switch.o legacy.o
+dsa_core-y += dsa.o dsa2.o legacy.o port.o slave.o switch.o
 
 # tagging formats
 dsa_core-$(CONFIG_NET_DSA_TAG_BRCM) += tag_brcm.o

diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
index c274130e3ac98f2d27572e39170c5522f1dc318d..cda218cd9b0550362a41ed5e61761a0b1b35033f 100644 (file)
--- a/net/dsa/dsa_priv.h
+++ b/net/dsa/dsa_priv.h
@@ -60,6 +60,11 @@ void dsa_cpu_port_ethtool_restore(struct dsa_switch *ds);
 int dsa_legacy_register(void);
 void dsa_legacy_unregister(void);
 
+/* port.c */
+int dsa_port_set_state(struct dsa_port *dp, u8 state,
+                      struct switchdev_trans *trans);
+void dsa_port_set_state_now(struct dsa_port *dp, u8 state);
+
 /* slave.c */
 extern const struct dsa_device_ops notag_netdev_ops;
 void dsa_slave_mii_bus_init(struct dsa_switch *ds);

diff --git a/net/dsa/port.c b/net/dsa/port.c
new file mode 100644 (file)
index 0000000..6cc4704
--- /dev/null
+++ b/net/dsa/port.c
@@ -0,0 +1,55 @@
+/*
+ * Handling of a single switch port
+ *
+ * Copyright (c) 2017 Savoir-faire Linux Inc.
+ *     Vivien Didelot <vivien.didelot@savoirfairelinux.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/if_bridge.h>
+
+#include "dsa_priv.h"
+
+int dsa_port_set_state(struct dsa_port *dp, u8 state,
+                      struct switchdev_trans *trans)
+{
+       struct dsa_switch *ds = dp->ds;
+       int port = dp->index;
+
+       if (switchdev_trans_ph_prepare(trans))
+               return ds->ops->port_stp_state_set ? 0 : -EOPNOTSUPP;
+
+       if (ds->ops->port_stp_state_set)
+               ds->ops->port_stp_state_set(ds, port, state);
+
+       if (ds->ops->port_fast_age) {
+               /* Fast age FDB entries or flush appropriate forwarding database
+                * for the given port, if we are moving it from Learning or
+                * Forwarding state, to Disabled or Blocking or Listening state.
+                */
+
+               if ((dp->stp_state == BR_STATE_LEARNING ||
+                    dp->stp_state == BR_STATE_FORWARDING) &&
+                   (state == BR_STATE_DISABLED ||
+                    state == BR_STATE_BLOCKING ||
+                    state == BR_STATE_LISTENING))
+                       ds->ops->port_fast_age(ds, port);
+       }
+
+       dp->stp_state = state;
+
+       return 0;
+}
+
+void dsa_port_set_state_now(struct dsa_port *dp, u8 state)
+{
+       int err;
+
+       err = dsa_port_set_state(dp, state, NULL);
+       if (err)
+               pr_err("DSA: failed to set STP state %u (%d)\n", state, err);
+}

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index b0150f79dcddc20f7c58b9ba6bac4d2aca625bfb..2c57c7205aa3dc6f4f52f5a24a66f981f1815ba7 100644 (file)
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -84,46 +84,6 @@ static inline bool dsa_port_is_bridged(struct dsa_port *dp)
        return !!dp->bridge_dev;
 }
 
-static int dsa_port_set_state(struct dsa_port *dp, u8 state,
-                             struct switchdev_trans *trans)
-{
-       struct dsa_switch *ds = dp->ds;
-       int port = dp->index;
-
-       if (switchdev_trans_ph_prepare(trans))
-               return ds->ops->port_stp_state_set ? 0 : -EOPNOTSUPP;
-
-       if (ds->ops->port_stp_state_set)
-               ds->ops->port_stp_state_set(ds, port, state);
-
-       if (ds->ops->port_fast_age) {
-               /* Fast age FDB entries or flush appropriate forwarding database
-                * for the given port, if we are moving it from Learning or
-                * Forwarding state, to Disabled or Blocking or Listening state.
-                */
-
-               if ((dp->stp_state == BR_STATE_LEARNING ||
-                    dp->stp_state == BR_STATE_FORWARDING) &&
-                   (state == BR_STATE_DISABLED ||
-                    state == BR_STATE_BLOCKING ||
-                    state == BR_STATE_LISTENING))
-                       ds->ops->port_fast_age(ds, port);
-       }
-
-       dp->stp_state = state;
-
-       return 0;
-}
-
-static void dsa_port_set_state_now(struct dsa_port *dp, u8 state)
-{
-       int err;
-
-       err = dsa_port_set_state(dp, state, NULL);
-       if (err)
-               pr_err("DSA: failed to set STP state %u (%d)\n", state, err);
-}
-
 static int dsa_slave_open(struct net_device *dev)
 {
        struct dsa_slave_priv *p = netdev_priv(dev);