ssb: Fix context assertion in ssb_pcicore_dev_irqvecs_enable
authorMichael Buesch <mb@bu3sch.de>
Mon, 2 Jun 2008 14:15:23 +0000 (16:15 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 4 Jun 2008 19:57:10 +0000 (15:57 -0400)
This fixes a context assertion in ssb that makes b44 print
out warnings on resume.

This fixes the following kernel oops:
http://www.kerneloops.org/oops.php?number=12732
http://www.kerneloops.org/oops.php?number=11410

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/ssb/driver_pcicore.c

index 75def13e797dddece3f3ea1a02085dabbb03062e..d28c53868093ce533c88e9b88a80334d9ac5ebca 100644 (file)
@@ -537,12 +537,12 @@ int ssb_pcicore_dev_irqvecs_enable(struct ssb_pcicore *pc,
        int err = 0;
        u32 tmp;
 
-       might_sleep();
-
        if (!pdev)
                goto out;
        bus = pdev->bus;
 
+       might_sleep_if(pdev->id.coreid != SSB_DEV_PCI);
+
        /* Enable interrupts for this device. */
        if (bus->host_pci &&
            ((pdev->id.revision >= 6) || (pdev->id.coreid == SSB_DEV_PCIE))) {