b43: Fix assigning negative value to unsigned variable
authorHaowen Bai <baihaowen@meizu.com>
Fri, 25 Mar 2022 10:15:15 +0000 (18:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:53:44 +0000 (16:53 +0200)
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]

fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1648203315-28093-1-git-send-email-baihaowen@meizu.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/broadcom/b43/phy_n.c

index d1afa74aa144b0781b023d637ff8b8b4ba4f31b7..9cbc17c2751cf91a7412e286d781e6636095bcf1 100644 (file)
@@ -594,7 +594,7 @@ static void b43_nphy_adjust_lna_gain_table(struct b43_wldev *dev)
        u16 data[4];
        s16 gain[2];
        u16 minmax[2];
-       static const u16 lna_gain[4] = { -2, 10, 19, 25 };
+       static const s16 lna_gain[4] = { -2, 10, 19, 25 };
 
        if (nphy->hang_avoid)
                b43_nphy_stay_in_carrier_search(dev, 1);