dm mpath: print more useful warnings in multipath_message()
authorJose Castillo <jcastillo@redhat.com>
Wed, 29 Jan 2014 16:52:45 +0000 (17:52 +0100)
committerMike Snitzer <snitzer@redhat.com>
Thu, 27 Mar 2014 20:56:25 +0000 (16:56 -0400)
The warning message "Unrecognised multipath message received" is
displayed in two different situations in multipath_message(): when the
number of arguments passed is invalid and when the string passed in
argv[0] is not recognized.

Make it easier to identify where the problem is by making these warnings
more specific with additional context for each case.

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c

index b1fb01efd56cf2c13d3806009cce51611858ba44..aa009e86587189a20a4ccf4734ad9d999cb5701f 100644 (file)
@@ -1478,7 +1478,7 @@ static int multipath_message(struct dm_target *ti, unsigned argc, char **argv)
        }
 
        if (argc != 2) {
-               DMWARN("Unrecognised multipath message received.");
+               DMWARN("Invalid multipath message arguments. Expected 2 arguments, got %d.", argc);
                goto out;
        }
 
@@ -1496,7 +1496,7 @@ static int multipath_message(struct dm_target *ti, unsigned argc, char **argv)
        else if (!strcasecmp(argv[0], "fail_path"))
                action = fail_path;
        else {
-               DMWARN("Unrecognised multipath message received.");
+               DMWARN("Unrecognised multipath message received: %s", argv[0]);
                goto out;
        }