iommu/omap: Remove redundant clock handling on ISR
authorOmar Ramirez Luna <omar.luna@linaro.org>
Tue, 20 Nov 2012 01:05:48 +0000 (19:05 -0600)
committerJoerg Roedel <joro@8bytes.org>
Mon, 3 Dec 2012 17:47:30 +0000 (18:47 +0100)
For the interrupt to be generated, the mmu clock should be already
enabled while translating a virtual address, so, this call to clock
handling is just increasing/decreasing the counter.

This works now, because its users need the same clock and they
indirectly power the mmu, in this interrupt context the handling of
clocks inside the ISR doesn't seem to be needed nor helping.

Next patch should also correct the dependency on clients to handle
iommu clocks.

Signed-off-by: Omar Ramirez Luna <omar.luna@linaro.org>
Tested-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
drivers/iommu/omap-iommu.c

index badc17c2bcb4302505860faa02c7b23e02c2be7e..6b1288cddaef4ad59522eac79e71c22e9a5cc88b 100644 (file)
@@ -807,9 +807,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
        if (!obj->refcount)
                return IRQ_NONE;
 
-       clk_enable(obj->clk);
        errs = iommu_report_fault(obj, &da);
-       clk_disable(obj->clk);
        if (errs == 0)
                return IRQ_HANDLED;