projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: b633353)
rocker: fix rocker_world_port_obj_vlan_add()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 23 Feb 2016 09:37:52 +0000 (12:37 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Feb 2016 18:12:31 +0000 (13:12 -0500)
We were changing return values and accidentally made
rocker_world_port_obj_vlan_add() into a no-op.

Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker_main.c patch | blob | blame | history

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index acafbf870182f9e5798a33d4159ac5fd1744555a..28b775e5a9ad459ccd4e1a6dc1ebe5fde4df7cd1 100644 (file)
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -1598,7 +1598,6 @@ rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port,
 
        if (!wops->port_obj_vlan_add)
                return -EOPNOTSUPP;
-               return 0;
        return wops->port_obj_vlan_add(rocker_port, vlan, trans);
 }