ASoC: add missing clk_put to nuc900-ac97
authorJulia Lawall <julia@diku.dk>
Wed, 1 Jun 2011 17:10:05 +0000 (19:10 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 1 Jun 2011 18:20:22 +0000 (19:20 +0100)
This goto is after the call to clk_get, so it should go to the label that
includes a call to clk_put.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/nuc900/nuc900-ac97.c

index dac6732da9695dfda940e78c98a5d58961b93955..9c0edad90d8b4b3591c7c3a23f4c03b9e42594c1 100644 (file)
@@ -356,7 +356,7 @@ static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev)
        nuc900_audio->irq_num = platform_get_irq(pdev, 0);
        if (!nuc900_audio->irq_num) {
                ret = -EBUSY;
-               goto out2;
+               goto out3;
        }
 
        nuc900_ac97_data = nuc900_audio;