tracing/events: Only define remove_subsystem_dir() if CONFIG_MODULES
authorFrederic Weisbecker <fweisbec@gmail.com>
Thu, 6 Aug 2009 05:32:21 +0000 (07:32 +0200)
committerFrederic Weisbecker <fweisbec@gmail.com>
Thu, 6 Aug 2009 05:32:21 +0000 (07:32 +0200)
If we disable modules, we get the following warning in ftrace events
file:

kernel/trace/trace_events.c:912: attention : ‘remove_subsystem_dir’ defined but not used

remove_subystem_dir() is useless if !CONFIG_MODULES, then move it to
the appropriate #ifdef section of trace_events.c

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 90cf9360e14058bc0052c81711460b51ce6d9417..70ecb7653b460b31da2d4804308b5761dfb7f4ff 100644 (file)
@@ -908,32 +908,6 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
        return system->entry;
 }
 
-static void remove_subsystem_dir(const char *name)
-{
-       struct event_subsystem *system;
-
-       if (strcmp(name, TRACE_SYSTEM) == 0)
-               return;
-
-       list_for_each_entry(system, &event_subsystems, list) {
-               if (strcmp(system->name, name) == 0) {
-                       if (!--system->nr_events) {
-                               struct event_filter *filter = system->filter;
-
-                               debugfs_remove_recursive(system->entry);
-                               list_del(&system->list);
-                               if (filter) {
-                                       kfree(filter->filter_string);
-                                       kfree(filter);
-                               }
-                               kfree(system->name);
-                               kfree(system);
-                       }
-                       break;
-               }
-       }
-}
-
 static int
 event_create_dir(struct ftrace_event_call *call, struct dentry *d_events,
                 const struct file_operations *id,
@@ -1018,6 +992,32 @@ struct ftrace_module_file_ops {
        struct file_operations          filter;
 };
 
+static void remove_subsystem_dir(const char *name)
+{
+       struct event_subsystem *system;
+
+       if (strcmp(name, TRACE_SYSTEM) == 0)
+               return;
+
+       list_for_each_entry(system, &event_subsystems, list) {
+               if (strcmp(system->name, name) == 0) {
+                       if (!--system->nr_events) {
+                               struct event_filter *filter = system->filter;
+
+                               debugfs_remove_recursive(system->entry);
+                               list_del(&system->list);
+                               if (filter) {
+                                       kfree(filter->filter_string);
+                                       kfree(filter);
+                               }
+                               kfree(system->name);
+                               kfree(system);
+                       }
+                       break;
+               }
+       }
+}
+
 static struct ftrace_module_file_ops *
 trace_create_file_ops(struct module *mod)
 {