projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 1b51e98)
UBIFS: minor cleanup: use S_ISREG helper
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Thu, 26 May 2011 06:43:34 +0000 (09:43 +0300)
committerArtem Bityutskiy <dedekind1@gmail.com>
Mon, 4 Jul 2011 07:54:26 +0000 (10:54 +0300)
Instead of using long "(inode->i_mode & S_IFMT) != S_IFREG" expression, use
shorted "!S_ISREG(inode->i_mode)".

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
fs/ubifs/super.c patch | blob | blame | history

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index de82c5d04ab9a42194320e11ec93e8461b958432..285038548da9036f82cfb0569c64c8915286a8aa 100644 (file)
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -85,7 +85,7 @@ static int validate_inode(struct ubifs_info *c, const struct inode *inode)
        if (ui->data_len < 0 || ui->data_len > UBIFS_MAX_INO_DATA)
                return 4;
 
-       if (ui->xattr && (inode->i_mode & S_IFMT) != S_IFREG)
+       if (ui->xattr && !S_ISREG(inode->i_mode))
                return 5;
 
        if (!ubifs_compr_present(ui->compr_type)) {