USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Jan 2013 07:41:38 +0000 (10:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jan 2013 23:49:00 +0000 (15:49 -0800)
The callers expect this function to return zero on success or -EIO if it
times out.  The type should be int instead of unsigned short.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/c67x00/c67x00-ll-hpi.c

index a9636f43bca20d99791a300f557c145747dc2216..3a1ca4dfc83ac26aa4af5e0e6ea68a24962d0e1e 100644 (file)
@@ -237,7 +237,7 @@ void c67x00_ll_hpi_disable_sofeop(struct c67x00_sie *sie)
 /* -------------------------------------------------------------------------- */
 /* Transactions */
 
-static inline u16 ll_recv_msg(struct c67x00_device *dev)
+static inline int ll_recv_msg(struct c67x00_device *dev)
 {
        u16 res;