drm/radeon: Fail fb creation from imported dma-bufs.
authorChristopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Wed, 29 Mar 2017 04:00:54 +0000 (15:00 +1100)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 7 Apr 2017 16:20:38 +0000 (12:20 -0400)
Any use of the framebuffer will migrate it to VRAM, which is not sensible for
an imported dma-buf.

v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg.

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
CC: amd-gfx@lists.freedesktop.org
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_display.c

index 146297a702ab0fe95752fa72e581f86c1d917954..e765a638f90ce4b7e27ac4b909359a089b8ee1a9 100644 (file)
@@ -1354,6 +1354,12 @@ radeon_user_framebuffer_create(struct drm_device *dev,
                return ERR_PTR(-ENOENT);
        }
 
+       /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
+       if (obj->import_attach) {
+               DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
+               return ERR_PTR(-EINVAL);
+       }
+
        radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
        if (radeon_fb == NULL) {
                drm_gem_object_unreference_unlocked(obj);