Resolve TODOs related to `wcf1_reaction_type` table
authorMatthias Schmidt <gravatronics@live.com>
Fri, 27 Sep 2019 15:00:35 +0000 (17:00 +0200)
committerMatthias Schmidt <gravatronics@live.com>
Fri, 27 Sep 2019 15:00:35 +0000 (17:00 +0200)
wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php

index 6884f7afb9cc9cd12737636a4233044366a60c7e..f4cef76852eff83b7770e8fc6104cba00dba5310 100644 (file)
@@ -149,12 +149,11 @@ $tables = [
        DatabaseTable::create('wcf1_reaction_type')
                ->columns([
                        ObjectIdDatabaseTableColumn::create('reactionTypeID'),
-                       // TODO: is currently not `not null`
                        NotNullVarchar255DatabaseTableColumn::create('title'),
                        NotNullInt10DatabaseTableColumn::create('showOrder')
                                ->defaultValue(0),
-                       // TODO: should be varchar
-                       MediumtextDatabaseTableColumn::create('iconFile'),
+                       NotNullVarchar255DatabaseTableColumn::create('iconFile')
+                               ->defaultValue(''),
                        DefaultFalseBooleanDatabaseTableColumn::create('isDisabled')
                ])
                ->indices([