net: mediatek: remove incorrect dma_mask assignment
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:07:11 +0000 (15:07 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 17:06:26 +0000 (13:06 -0400)
Device drivers should not mess with the DMA mask directly,
but instead call dma_set_mask() etc if needed.

In case of the mtk_eth_soc driver, the mask already gets set
correctly when the device is created, and setting it again
is against the documented API.

This removes the incorrect setting.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 3e42204adfe54ec12654d4d6072ca9650cad73af..87f417712da02bfd1a14548f6048d742bceeb794 100644 (file)
@@ -1676,9 +1676,6 @@ static int mtk_probe(struct platform_device *pdev)
        struct mtk_eth *eth;
        int err;
 
-       pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
-       pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
-
        device_reset(&pdev->dev);
 
        match = of_match_device(of_mtk_match, &pdev->dev);