mfd: lm3533: Simplify function return logic
authorJavier Martinez Canillas <javier@osg.samsung.com>
Tue, 29 Sep 2015 11:26:08 +0000 (13:26 +0200)
committerLee Jones <lee.jones@linaro.org>
Fri, 30 Oct 2015 17:19:45 +0000 (17:19 +0000)
The invoked functions already return zero on success or a negative
errno code so there is no need to open code the logic in the caller.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/lm3533-core.c

index 643f3750e83079d11e7042c7e36e73ce20c26c19..193ecee1fa7e82427e7bae728a62bd259b982165 100644 (file)
@@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533,
        if (ret)
                return ret;
 
-       ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
-       if (ret)
-               return ret;
-
-       return 0;
+       return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
 }
 
 static int lm3533_device_init(struct lm3533 *lm3533)
@@ -613,11 +609,7 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
        lm3533->dev = &i2c->dev;
        lm3533->irq = i2c->irq;
 
-       ret = lm3533_device_init(lm3533);
-       if (ret)
-               return ret;
-
-       return 0;
+       return lm3533_device_init(lm3533);
 }
 
 static int lm3533_i2c_remove(struct i2c_client *i2c)