vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX
authorAsias He <asias@redhat.com>
Tue, 7 May 2013 06:51:49 +0000 (14:51 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 7 May 2013 08:11:08 +0000 (11:11 +0300)
It was disabled as a workaround. Now userspace bits work fine with it.
The broken version was not ever committed to QEMU, I guess the same is
true for nlkt.

So, let's enable it.

Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vhost/scsi.c

index 5179f7aa1b0bef8dee4dd813607bd2684ac29943..7014202972259f4d7046d5f4a110fe9a0cedef37 100644 (file)
@@ -162,14 +162,8 @@ enum {
        VHOST_SCSI_VQ_IO = 2,
 };
 
-/*
- * VIRTIO_RING_F_EVENT_IDX seems broken. Not sure the bug is in
- * kernel but disabling it helps.
- * TODO: debug and remove the workaround.
- */
 enum {
-       VHOST_SCSI_FEATURES = (VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)) |
-                             (1ULL << VIRTIO_SCSI_F_HOTPLUG)
+       VHOST_SCSI_FEATURES = VHOST_FEATURES | (1ULL << VIRTIO_SCSI_F_HOTPLUG)
 };
 
 #define VHOST_SCSI_MAX_TARGET  256