net: adjust array index
authorJulia Lawall <julia@diku.dk>
Thu, 28 Jul 2011 02:46:01 +0000 (02:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 1 Aug 2011 09:27:21 +0000 (02:27 -0700)
Convert array index from the loop bound to the loop index.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,ar;
@@

for(e1 = 0; e1 < e2; e1++) { <...
  ar[
- e2
+ e1
  ]
  ...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/igmp.c

index f1d27f6c9351d2a2bdc15d22fbb35ea270022f22..283c0a26e03f9ba2e3e0532638b6810fb4f7f349 100644 (file)
@@ -1718,7 +1718,7 @@ static int ip_mc_add_src(struct in_device *in_dev, __be32 *pmca, int sfmode,
 
                pmc->sfcount[sfmode]--;
                for (j=0; j<i; j++)
-                       (void) ip_mc_del1_src(pmc, sfmode, &psfsrc[i]);
+                       (void) ip_mc_del1_src(pmc, sfmode, &psfsrc[j]);
        } else if (isexclude != (pmc->sfcount[MCAST_EXCLUDE] != 0)) {
 #ifdef CONFIG_IP_MULTICAST
                struct ip_sf_list *psf;