Input: tnetv107x-keypad - make irqs signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 11 Nov 2013 07:31:17 +0000 (23:31 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 11 Nov 2013 08:01:44 +0000 (00:01 -0800)
There is a bug in keypad_probe() where we do:

kp->irq_press   = platform_get_irq_byname(pdev, "press");
kp->irq_release = platform_get_irq_byname(pdev, "release");
if (kp->irq_press < 0 || kp->irq_release < 0) {

The problem is that these irq variables are unsigned so the error
handling doesn't work.  I've changed them to signed values.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/tnetv107x-keypad.c

index 5f7b427dd7ed06e48b53aa6f0ae6c236af82dcfa..8bd24d52bf1bedd0438e0737350c640b6e3b38b8 100644 (file)
@@ -60,8 +60,8 @@ struct keypad_data {
        struct clk                      *clk;
        struct device                   *dev;
        spinlock_t                      lock;
-       u32                             irq_press;
-       u32                             irq_release;
+       int                             irq_press;
+       int                             irq_release;
        int                             rows, cols, row_shift;
        int                             debounce_ms, active_low;
        u32                             prev_keys[3];