spi: spi-coldfire-qspi: Drop extra spi_master_put in device remove function
authorGuenter Roeck <linux@roeck-us.net>
Fri, 17 Aug 2012 03:25:59 +0000 (20:25 -0700)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Fri, 17 Aug 2012 21:46:41 +0000 (22:46 +0100)
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is
complete; it reduces the device reference count to zero, which and results in
device memory being freed. The subsequent call to spi_master_put is unnecessary
and results in an access to free memory. Drop it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/spi/spi-coldfire-qspi.c

index b2d4b9e4e0105d53dff9a3c747bd535b6732a6b6..1a30b47465cb6c1526680c55f069a2b4e2eb7f85 100644 (file)
@@ -533,7 +533,6 @@ static int __devexit mcfqspi_remove(struct platform_device *pdev)
        iounmap(mcfqspi->iobase);
        release_mem_region(res->start, resource_size(res));
        spi_unregister_master(master);
-       spi_master_put(master);
 
        return 0;
 }