x86: provide readq()/writeq() on 32-bit too, cleanup
authorIngo Molnar <mingo@elte.hu>
Sun, 30 Nov 2008 08:33:55 +0000 (09:33 +0100)
committerIngo Molnar <mingo@elte.hu>
Sun, 30 Nov 2008 08:38:19 +0000 (09:38 +0100)
Impact: cleanup

Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/io.h

index 25946449df4f25d2cf1679be81ba1b419d84cc30..3ccfaf610c89c23460409ad6c169355d72d1cf5e 100644 (file)
@@ -55,21 +55,17 @@ build_mmio_write(__writeq, "q", unsigned long, "r", )
 #define __raw_readq __readq
 #define __raw_writeq writeq
 
-/* Let people know we have them */
-#define readq readq
-#define writeq writeq
-
 #else  /* CONFIG_X86_32 from here */
 
 static inline __u64 readq(const volatile void __iomem *addr)
 {
        const volatile u32 __iomem *p = addr;
-       u32 lh;
+       u32 low, high;
 
-       l = readl(p);
-       h = readl(p + 1);
+       low = readl(p);
+       high = readl(p + 1);
 
-       return l + ((u64)h << 32);
+       return low + ((u64)high << 32);
 }
 
 static inline void writeq(__u64 val, volatile void __iomem *addr)
@@ -78,11 +74,12 @@ static inline void writeq(__u64 val, volatile void __iomem *addr)
        writel(val >> 32, addr+4);
 }
 
+#endif
+
+/* Let people know that we have them */
 #define readq          readq
 #define writeq         writeq
 
-#endif
-
 extern int iommu_bio_merge;
 
 #ifdef CONFIG_X86_32