dmaengine: timb_dma: convert callback to helper function
authorDave Jiang <dave.jiang@intel.com>
Wed, 20 Jul 2016 20:13:22 +0000 (13:13 -0700)
committerVinod Koul <vinod.koul@intel.com>
Mon, 8 Aug 2016 02:41:41 +0000 (08:11 +0530)
This is in preperation of moving to a callback that provides results to the
callback for the transaction. The conversion will maintain current behavior
and the driver must convert to new callback mechanism at a later time in
order to receive results.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/timb_dma.c

index e82745aa42a8bfc5deaecfb62f39d1b2a2972278..896bafb7a53240e3bac1679a79177840fc81bcd1 100644 (file)
@@ -226,8 +226,7 @@ static void __td_start_dma(struct timb_dma_chan *td_chan)
 
 static void __td_finish(struct timb_dma_chan *td_chan)
 {
-       dma_async_tx_callback           callback;
-       void                            *param;
+       struct dmaengine_desc_callback  cb;
        struct dma_async_tx_descriptor  *txd;
        struct timb_dma_desc            *td_desc;
 
@@ -252,8 +251,7 @@ static void __td_finish(struct timb_dma_chan *td_chan)
        dma_cookie_complete(txd);
        td_chan->ongoing = false;
 
-       callback = txd->callback;
-       param = txd->callback_param;
+       dmaengine_desc_get_callback(txd, &cb);
 
        list_move(&td_desc->desc_node, &td_chan->free_list);
 
@@ -262,8 +260,7 @@ static void __td_finish(struct timb_dma_chan *td_chan)
         * The API requires that no submissions are done from a
         * callback, so we don't need to drop the lock here
         */
-       if (callback)
-               callback(param);
+       dmaengine_desc_callback_invoke(&cb, NULL);
 }
 
 static u32 __td_ier_mask(struct timb_dma *td)