IB/iser: Fix wrong calculation of protection buffer length

This length miss-calculation may cause a silent data corruption
in the DIX case and cause the device to reference unmapped area.

Fixes: d77e65350f2d ('libiscsi, iser: Adjust data_length to include protection information')
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c
index 20e859a6f1a63b2fede51dcb2b02b9b6f638a36e..76eb57b31a599a3c2388e06ecc21d5cead104238 100644 (file)
--- a/drivers/infiniband/ulp/iser/iser_initiator.c
+++ b/drivers/infiniband/ulp/iser/iser_initiator.c
@@ -409,8 +409,8 @@ int iser_send_command(struct iscsi_conn *conn,
        if (scsi_prot_sg_count(sc)) {
                prot_buf->buf  = scsi_prot_sglist(sc);
                prot_buf->size = scsi_prot_sg_count(sc);
-               prot_buf->data_len = data_buf->data_len >>
-                                    ilog2(sc->device->sector_size) * 8;
+               prot_buf->data_len = (data_buf->data_len >>
+                                    ilog2(sc->device->sector_size)) * 8;
        }
 
        if (hdr->flags & ISCSI_FLAG_CMD_READ) {