KVM: nVMX: validate eptp pointer
authorDavid Hildenbrand <david@redhat.com>
Thu, 10 Aug 2017 21:36:54 +0000 (23:36 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 11 Aug 2017 16:53:22 +0000 (18:53 +0200)
Let's reuse the function introduced with eptp switching.

We don't explicitly have to check against enable_ept_ad_bits, as this
is implicitly done when checking against nested_vmx_ept_caps in
valid_ept_address().

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx.c

index ed1074e98b8e8faa505b93fb782409ef41187b81..df8d2f127508dbbe262c65295c6f914d3b5eba01 100644 (file)
@@ -9721,18 +9721,15 @@ static unsigned long nested_ept_get_cr3(struct kvm_vcpu *vcpu)
 
 static int nested_ept_init_mmu_context(struct kvm_vcpu *vcpu)
 {
-       bool wants_ad;
-
        WARN_ON(mmu_is_nested(vcpu));
-       wants_ad = nested_ept_ad_enabled(vcpu);
-       if (wants_ad && !enable_ept_ad_bits)
+       if (!valid_ept_address(vcpu, nested_ept_get_cr3(vcpu)))
                return 1;
 
        kvm_mmu_unload(vcpu);
        kvm_init_shadow_ept_mmu(vcpu,
                        to_vmx(vcpu)->nested.nested_vmx_ept_caps &
                        VMX_EPT_EXECUTE_ONLY_BIT,
-                       wants_ad);
+                       nested_ept_ad_enabled(vcpu));
        vcpu->arch.mmu.set_cr3           = vmx_set_cr3;
        vcpu->arch.mmu.get_cr3           = nested_ept_get_cr3;
        vcpu->arch.mmu.inject_page_fault = nested_ept_inject_page_fault;