powerpc/powermac: Cleaning up missing null-terminate in conjunction with strncpy
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Sat, 26 Jul 2014 16:45:05 +0000 (18:45 +0200)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 17 Mar 2015 04:55:52 +0000 (15:55 +1100)
Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
And removed unnecessary magic numbers.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/powermac/bootx_init.c

index 3e91ef538114c6adb14401b6e33b5b247f5aa3e4..76f5013c35e5c1cedb9f70b09401b3cc76ec5ab5 100644 (file)
@@ -246,7 +246,7 @@ static void __init bootx_scan_dt_build_strings(unsigned long base,
                DBG(" detected display ! adding properties names !\n");
                bootx_dt_add_string("linux,boot-display", mem_end);
                bootx_dt_add_string("linux,opened", mem_end);
-               strncpy(bootx_disp_path, namep, 255);
+               strlcpy(bootx_disp_path, namep, sizeof(bootx_disp_path));
        }
 
        /* get and store all property names */