ANDROID: Kbuild, LLVMLinux: allow overriding clang target triple
authorGreg Hackmann <ghackmann@google.com>
Tue, 25 Oct 2016 20:59:59 +0000 (13:59 -0700)
committerAlistair Strachan <astrachan@google.com>
Wed, 28 Nov 2018 02:06:36 +0000 (18:06 -0800)
Android has an unusual setup where the kernel needs to target
[arch]-linux-gnu to avoid Android userspace-specific flags and
optimizations, but AOSP doesn't ship a matching binutils.

Add a new variable CLANG_TRIPLE which can override the "-target" triple
used to compile the kernel, while using a different CROSS_COMPILE to
pick the binutils/gcc installation.  For Android you'd do something
like:

  export CLANG_TRIPLE=aarch64-linux-gnu-
  export CROSS_COMPILE=aarch64-linux-android-

If you don't need something like this, leave CLANG_TRIPLE unset and it
will default to CROSS_COMPILE.

Change-Id: I85d63599c6ab8ed458071cdf9197d85b1f7f150b
Signed-off-by: Greg Hackmann <ghackmann@google.com>
[astrachan: Added a script to check for incorrectly falling back to the
            default when CLANG_TRIPLE is unset]
Bug: 118439987
Signed-off-by: Alistair Strachan <astrachan@google.com>
Makefile
scripts/clang-android.sh [new file with mode: 0755]

index e7585b87582b41395f5bc2fe8d7a7bde4566eff9..663373f80220a5dea40440c90a7860cd925dddca 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -480,7 +480,11 @@ endif
 
 ifeq ($(cc-name),clang)
 ifneq ($(CROSS_COMPILE),)
-CLANG_TARGET   := --target=$(notdir $(CROSS_COMPILE:%-=%))
+CLANG_TRIPLE   ?= $(CROSS_COMPILE)
+CLANG_TARGET   := --target=$(notdir $(CLANG_TRIPLE:%-=%))
+ifeq ($(shell $(srctree)/scripts/clang-android.sh $(CC) $(CLANG_TARGET)), y)
+$(error "Clang with Android --target detected. Did you specify CLANG_TRIPLE?")
+endif
 GCC_TOOLCHAIN  := $(realpath $(dir $(shell which $(LD)))/..)
 endif
 ifneq ($(GCC_TOOLCHAIN),)
diff --git a/scripts/clang-android.sh b/scripts/clang-android.sh
new file mode 100755 (executable)
index 0000000..9186c4f
--- /dev/null
@@ -0,0 +1,4 @@
+#!/bin/sh
+# SPDX-License-Identifier: GPL-2.0
+
+$* -dM -E - </dev/null 2>&1 | grep -q __ANDROID__ && echo "y"