[SCTP]: More trivial sctp annotations.
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 21 Nov 2006 01:26:34 +0000 (17:26 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Sun, 3 Dec 2006 05:27:13 +0000 (21:27 -0800)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/outqueue.c
net/sctp/sm_make_chunk.c
net/sctp/tsnmap.c
net/sctp/ulpevent.c

index 739582415bf6d84b98d61235ac6a220b9a01cd34..c9148484b2ff20a2f8ce27deef2f4e856e76acdc 100644 (file)
@@ -1632,7 +1632,7 @@ pass:
 }
 
 static inline int sctp_get_skip_pos(struct sctp_fwdtsn_skip *skiplist,
-                                   int nskips, __u16 stream)
+                                   int nskips, __be16 stream)
 {
        int i;
 
index 9674e6e3205b74fbf8403da2706887650e6a602f..51cab806abd8b9ef9b2c1428948b5c9d573bc573 100644 (file)
@@ -775,7 +775,7 @@ struct sctp_chunk *sctp_make_abort_no_data(
        const struct sctp_chunk *chunk, __u32 tsn)
 {
        struct sctp_chunk *retval;
-       __u32 payload;
+       __be32 payload;
 
        retval = sctp_make_abort(asoc, chunk, sizeof(sctp_errhdr_t)
                                 + sizeof(tsn));
@@ -1195,10 +1195,9 @@ void sctp_chunk_assign_ssn(struct sctp_chunk *chunk)
                        ssn = sctp_ssn_next(&chunk->asoc->ssnmap->out, sid);
                else
                        ssn = sctp_ssn_peek(&chunk->asoc->ssnmap->out, sid);
-               ssn = htons(ssn);
        }
 
-       chunk->subh.data_hdr->ssn = ssn;
+       chunk->subh.data_hdr->ssn = htons(ssn);
        chunk->has_ssn = 1;
 }
 
@@ -1539,8 +1538,8 @@ malformed:
  ********************************************************************/
 
 struct __sctp_missing {
-       __u32 num_missing;
-       __u16 type;
+       __be32 num_missing;
+       __be16 type;
 }  __attribute__((packed));
 
 /*
@@ -2364,7 +2363,7 @@ static struct sctp_chunk *sctp_make_asconf_ack(const struct sctp_association *as
 }
 
 /* Add response parameters to an ASCONF_ACK chunk. */
-static void sctp_add_asconf_response(struct sctp_chunk *chunk, __u32 crr_id,
+static void sctp_add_asconf_response(struct sctp_chunk *chunk, __be32 crr_id,
                              __be16 err_code, sctp_addip_param_t *asconf_param)
 {
        sctp_addip_param_t      ack_param;
index ac4fae161bc727e3233d5836a03f491a63286bec..42d9498c64fadde9e6279cc8527734237fecc38b 100644 (file)
@@ -401,13 +401,14 @@ __u16 sctp_tsnmap_num_gabs(struct sctp_tsnmap *map)
 
        /* Refresh the gap ack information. */
        if (sctp_tsnmap_has_gap(map)) {
+               __u16 start, end;
                sctp_tsnmap_iter_init(map, &iter);
                while (sctp_tsnmap_next_gap_ack(map, &iter,
-                                               &map->gabs[gabs].start,
-                                               &map->gabs[gabs].end)) {
+                                               &start,
+                                               &end)) {
 
-                       map->gabs[gabs].start = htons(map->gabs[gabs].start);
-                       map->gabs[gabs].end = htons(map->gabs[gabs].end);
+                       map->gabs[gabs].start = htons(start);
+                       map->gabs[gabs].end = htons(end);
                        gabs++;
                        if (gabs >= SCTP_MAX_GABS)
                                break;
index a015283a90870bcb5f9c5c85d08d5742c865813a..e255a709f1b7ed867d4985b9da51f86fdee96cd5 100644 (file)
@@ -351,7 +351,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_remote_error(
        struct sctp_remote_error *sre;
        struct sk_buff *skb;
        sctp_errhdr_t *ch;
-       __u16 cause;
+       __be16 cause;
        int elen;
 
        ch = (sctp_errhdr_t *)(chunk->skb->data);