scsi/NCR5380: reduce depth of sun3_scsi nested includes
authorFinn Thain <fthain@telegraphics.com.au>
Tue, 18 Mar 2014 00:42:23 +0000 (11:42 +1100)
committerChristoph Hellwig <hch@lst.de>
Wed, 28 May 2014 10:11:33 +0000 (12:11 +0200)
Move the #include "NCR5380.h" out of the sun3_scsi.h header file and into
the driver .c files, like all the other NCR5380 drivers in the tree.

This improves uniformity and reduces the depth of nested includes. The
sequence of #include's, #define's and #if's no longer does my head in.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Acked-by: Sam Creasey <sammy@sammy.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/sun3_scsi.c
drivers/scsi/sun3_scsi.h
drivers/scsi/sun3_scsi_vme.c

index 99466e64e507cd5883fe603838416a642a1ccdd9..ac9c29b55a3371d08fba4ac4f20304bc11cbeb38 100644 (file)
@@ -71,6 +71,7 @@
 #include "scsi.h"
 #include <scsi/scsi_host.h>
 #include "sun3_scsi.h"
+#include "NCR5380.h"
 
 /* #define OLDDMA */
 
index 5d2ca648657f99492ffb33112f2cb264471bb09f..e96a37cf06ac117f45246e4f60e6745384a0a119 100644 (file)
@@ -29,8 +29,8 @@
  * 1+ (800) 334-5454
  */
 
-#ifndef SUN3_NCR5380_H
-#define SUN3_NCR5380_H
+#ifndef SUN3_SCSI_H
+#define SUN3_SCSI_H
 
 #define SUN3SCSI_PUBLIC_RELEASE 1
 
@@ -182,7 +182,5 @@ struct sun3_udc_regs {
 
 #define VME_DATA24 0x3d00
 
-#include "NCR5380.h"
-
-#endif /* SUN3_NCR5380_H */
+#endif /* SUN3_SCSI_H */
 
index 95031d571cd0b5fd8e0b9fc5a027a278d3b92ad5..9e7974b56f12fabdc51a776efd343dea94febed3 100644 (file)
@@ -42,6 +42,7 @@
 #include "initio.h"
 #include <scsi/scsi_host.h>
 #include "sun3_scsi.h"
+#include "NCR5380.h"
 
 extern int sun3_map_test(unsigned long, char *);