ARM: perf: remove mysterious compiler barrier
authorWill Deacon <will.deacon@arm.com>
Sat, 28 Jul 2012 15:44:38 +0000 (16:44 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 23 Aug 2012 10:35:51 +0000 (11:35 +0100)
There's a rather strange compiler barrier in the PMU disabling code
which was presumably placed there by aliens. There's no valid reason for
the barrier and one can only suspect that it's up to no good.

This patch removes it before it has a chance to spread.

Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/kernel/perf_event.c

index 1ac1531dcfef60f866926fe84b2be2d6211ecb62..22ed5120a6edc2090ac957a54437dbfa33a026c5 100644 (file)
@@ -223,7 +223,6 @@ armpmu_stop(struct perf_event *event, int flags)
         */
        if (!(hwc->state & PERF_HES_STOPPED)) {
                armpmu->disable(hwc, hwc->idx);
-               barrier(); /* why? */
                armpmu_event_update(event, hwc, hwc->idx);
                hwc->state |= PERF_HES_STOPPED | PERF_HES_UPTODATE;
        }