dmaengine: coh901318: fix integer overflow when shifting more than 32 places

Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
be more than 32 places, which leads to a 32 bit integer overflow. Fix this
by using 1ULL instead of 1 before shifting it.  Also add braces on the
for-loop to keep with coding style conventions.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
index a373ecacfabad8cb31c947ef22a2acfb5db01856..5b1d4a39b30b7ed8eac219a1a624c063ab691a15 100644 (file)
--- a/drivers/dma/coh901318.c
+++ b/drivers/dma/coh901318.c
@@ -1352,9 +1352,10 @@ static int coh901318_debugfs_read(struct file *file, char __user *buf,
 
        tmp += sprintf(tmp, "DMA -- enabled dma channels\n");
 
-       for (i = 0; i < U300_DMA_CHANNELS; i++)
-               if (started_channels & (1 << i))
+       for (i = 0; i < U300_DMA_CHANNELS; i++) {
+               if (started_channels & (1ULL << i))
                        tmp += sprintf(tmp, "channel %d\n", i);
+       }
 
        tmp += sprintf(tmp, "Pool alloc nbr %d\n", pool_count);