ixgbe: show <2% for encoding loss on PCIe Gen3
authorJacob Keller <jacob.e.keller@intel.com>
Fri, 18 Oct 2013 05:09:19 +0000 (05:09 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 29 Oct 2013 10:38:26 +0000 (03:38 -0700)
This patch updates the ixgbe_check_minimum_link function to correctly show that
there is some minor loss of encoding, even though we don't calculate it in the
max GT/s equation. It is small enough to not bother, but is better to report it
than not.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index ee90dfb518aaa9574f1e8b42eaf1014f14e86e60..9753c8a07e8d32116861b57f16cb10f746f35569 100644 (file)
@@ -245,7 +245,7 @@ static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter,
                max_gts = 4 * width;
                break;
        case PCIE_SPEED_8_0GT:
-               /* 128b/130b encoding only reduces throughput by 1% */
+               /* 128b/130b encoding reduces throughput by less than 2% */
                max_gts = 8 * width;
                break;
        default:
@@ -263,7 +263,7 @@ static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter,
                   width,
                   (speed == PCIE_SPEED_2_5GT ? "20%" :
                    speed == PCIE_SPEED_5_0GT ? "20%" :
-                   speed == PCIE_SPEED_8_0GT ? "N/a" :
+                   speed == PCIE_SPEED_8_0GT ? "<2%" :
                    "Unknown"));
 
        if (max_gts < expected_gts) {