projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: dd5619c)
pciehp: Remove unnecessary check in pciehp_ctrl.c
authorEric Sesterhenn <snakebyte@gmx.de>
Sun, 24 Sep 2006 22:56:53 +0000 (00:56 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 18 Oct 2006 18:36:10 +0000 (11:36 -0700)
this was spotted by coverity (cid #819). We dereference p_slot
earlier in the function, and i found no way it could become NULL
anywhere.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/hotplug/pciehp_ctrl.c patch | blob | blame | history

diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
index c206a3d63b632d1cca23d24265d894d3f1c115cb..372c63e35aa99b47561c746f11fe00dbd661d9c3 100644 (file)
--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -797,8 +797,7 @@ int pciehp_enable_slot(struct slot *p_slot)
                p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
        }
 
-       if (p_slot)
-               update_slot_info(p_slot);
+       update_slot_info(p_slot);
 
        mutex_unlock(&p_slot->ctrl->crit_sect);
        return rc;