perf tests record: No need to test an array against NULL
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 13 Feb 2017 20:04:05 +0000 (17:04 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 13 Feb 2017 20:22:34 +0000 (17:22 -0300)
It will always evaluate to 'true', as clang warns:

    CC       /tmp/build/perf/tests/perf-record.o
    CC       /tmp/build/perf/tests/evsel-roundtrip-name.o
  tests/perf-record.c:69:24: error: comparison of array 'argv' equal to a null pointer is always false [-Werror,-Wtautological-pointer-compare]
          if (evlist == NULL || argv == NULL) {
                                ^~~~    ~~~~
  1 error generated.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-o4977g6p9b3peak9ct6ef48q@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/perf-record.c

index 8f2e1de6d0eae93d0bb8de2e12602f9898176136..541da7a68f91fc4631c0c20f313a9b58f720771b 100644 (file)
@@ -66,7 +66,7 @@ int test__PERF_RECORD(int subtest __maybe_unused)
        if (evlist == NULL) /* Fallback for kernels lacking PERF_COUNT_SW_DUMMY */
                evlist = perf_evlist__new_default();
 
-       if (evlist == NULL || argv == NULL) {
+       if (evlist == NULL) {
                pr_debug("Not enough memory to create evlist\n");
                goto out;
        }