pinctrl: pinctrl-imx.c: Cleaning up if unsigned is less than zero
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thu, 26 Jun 2014 11:28:16 +0000 (13:28 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Jul 2014 12:08:32 +0000 (14:08 +0200)
Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-imx.c

index a24448e5d3996ee81a490710545626be8c83f0a2..946d594a64dddc929884d7306055afcdd63e8efc 100644 (file)
@@ -515,7 +515,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
        /* Initialise function */
        func->name = np->name;
        func->num_groups = of_get_child_count(np);
-       if (func->num_groups <= 0) {
+       if (func->num_groups == 0) {
                dev_err(info->dev, "no groups defined in %s\n", np->full_name);
                return -EINVAL;
        }